Sobes.tech
Middle+

What do you pay attention to when conducting a code review?

sobes.tech AI

Answer from AI

  • Compliance with the project's code style
  • Readability and understandability of the code
  • Absence of code duplication (DRY)
  • Proper use of architectural patterns and design principles (SOLID)
  • Error handling and edge cases
  • No memory leaks (strong reference cycles, unmanaged objects)
  • Use of appropriate data structures and algorithms for solving the problem
  • Presence of comments and their relevance
  • Availability of unit tests and their coverage
  • Performance optimization (if applicable)
  • Atomicity and readability of commits
  • Compliance of implementation with the task and requirements
// Example of checking for memory leaks
class Parent {
    var child: Child?
}

class Child {
    weak var parent: Parent? // Using weak to avoid strong reference cycle
}
// Example of DRY check
func computeSum(_ a: Int, _ b: Int) -> Int {
    // Common logic
    return a + b
}

func processNumbers(_ x: Int, _ y: Int) {
    let result = computeSum(x, y)
    // Additional processing
    print(result)
}

func handleValues(_ p: Int, _ q: Int) {
    let result = computeSum(p, q) // Reusing computeSum
    // Additional processing
    print(result * 2)
}
Aspect What I check
Readability Variable, function, class names; indentation
Correctness Logic, error handling, edge cases
Performance Loops, complex calculations, working with collections
Testing Presence and quality of tests
Architecture/Design Compliance with patterns, principles
What do you pay attention to when conducting a code… - sobes.tech